[Webkit-unassigned] [Bug 23351] Add preference to not select when right-clicked

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23351


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73666|review?                     |review-
               Flag|                            |




--- Comment #36 from Antonio Gomes <tonikitoo at webkit.org>  2010-11-11 20:42:49 PST ---
(From update of attachment 73666)
View in context: https://bugs.webkit.org/attachment.cgi?id=73666&action=review

> WebCore/editing/EditingBehavior.h:61
> +    // On Mac/Unix, when processing a contextual click, the object being clicked upon should be selected.
> +    bool shouldSelectOnContextualMenuClick() const { return m_type == EditingMacBehavior || m_type == EditingUnixBehavior; }

Sorry Avi, maybe I misexplained: it is a Mac-specific behavior.

> LayoutTests/editing/selection/context-menu-text-selection.html:34
> +    var onWinPlatform = navigator.userAgent.search(/\bWindows\b/) != -1;
> +    if (onWinPlatform) {
> +        if (window.getSelection().type != "None")

This is not the right way to test this. See LayoutTestController::setEditingBehavior. grep for it. It basically makes it possible to test all editing behavior and having test expectations shared cross all platforms..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.