[Webkit-unassigned] [Bug 48809] Chromium WebKit API needs WebFrame::lastCommittedHistoryItem()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48809





--- Comment #25 from Charles Reis <creis at chromium.org>  2010-11-11 19:05:55 PST ---
Found the problem with the pushstate tests.  They revealed that we were not sending a content state update for same-page back/forward navigations before (because m_previousItem was 0).  After my change, we were sending updates, but with the wrong value for m_previousItem.

The problem was that HistoryController::m_previousItem was not being updated for back/forward navigations-- it's perfectly safe to send a content state update, as long as it's the correct one.

The new patch I'm uploading ensures m_previousItem is correct in this case by updating it in HistoryController::setCurrentItem.  The layout tests I mention in comment 24 cover the change, but I'm running the rest of the tests to double check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.