[Webkit-unassigned] [Bug 49119] Add AudioNode custom bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49119


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73152|review?                     |review-
               Flag|                            |




--- Comment #3 from Kenneth Russell <kbr at google.com>  2010-11-11 15:00:44 PST ---
(From update of attachment 73152)
View in context: https://bugs.webkit.org/attachment.cgi?id=73152&action=review

Basically looks fine; r- for unnecessary checks.

> WebCore/bindings/js/JSAudioNodeCustom.cpp:42
> +    if (exec->argumentCount() > 3)
> +        return throwError(exec, createSyntaxError(exec, "Too many arguments"));

It isn't an error to pass too many arguments to a JavaScript function.

> WebCore/bindings/js/JSAudioNodeCustom.cpp:68
> +    if (exec->argumentCount() > 1)
> +        return throwError(exec, createSyntaxError(exec, "Too many arguments"));

Unnecessary check per above.

> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:45
> +    if (args.Length() > 3)
> +        return throwError("Too many arguments", V8Proxy::SyntaxError);

Unnecessary check per above.

> WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp:77
> +    if (args.Length() > 1)
> +        return throwError("Too many arguments", V8Proxy::SyntaxError);

Unnecessary check per above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.