[Webkit-unassigned] [Bug 49357] Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49357


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73565|review?                     |review-
               Flag|                            |




--- Comment #2 from Kenneth Russell <kbr at google.com>  2010-11-11 14:52:55 PST ---
(From update of attachment 73565)
View in context: https://bugs.webkit.org/attachment.cgi?id=73565&action=review

This looks good overall. r- for the unrelated header reorderings. If check-webkit-style is complaining then try webkit-patch upload to upload your next patch, which I believe will only run the style checker against the changed portions of your diff.

> WebCore/bindings/js/JSEventTarget.cpp:66
> -#include "SVGElementInstance.h"
>  #include "JSSVGElementInstance.h"
> +#include "SVGElementInstance.h"

This looks like an unrelated change that should go in a separate patch.

> WebCore/bindings/js/JSEventTarget.cpp:98
> -#include "JSFileReader.h"
>  #include "FileReader.h"
> +#include "JSFileReader.h"

This looks like an unrelated change that should go in a separate patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.