[Webkit-unassigned] [Bug 49132] [GTK] Use __attribute__((constructor)) to call webkit_init at library init time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49132





--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2010-11-11 13:44:45 PST ---
(In reply to comment #5)

Thanks for the review!

> > WebCore/platform/graphics/gtk/ImageGtk.cpp:46
> > +    if (!module) {
> > +        GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS | GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT,
> > +                          static_cast<LPCSTR>(getWebKitDataDirectory), &module);
> > +    }
> 

> Should not have the bracers here.

I think they've recently updated the rule at http://webkit.org/coding/coding-style.html: "One-line control clauses should not use braces unless comments are included or a single statement spans multiple lines."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.