[Webkit-unassigned] [Bug 48809] Chromium WebKit API needs WebFrame::lastCommittedHistoryItem()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48809





--- Comment #22 from Charles Reis <creis at chromium.org>  2010-11-11 13:23:54 PST ---
I dug a little deeper and found the root cause of why previousItem wasn't working for fragments.  As I mentioned in comment 18, HistoryController::updateForFrameLoadCompleted() is getting called before the content state is updated, which means m_previousItem is null when we need it.

It turns out this is because FrameLoader::loadInSameDocument() is simply calling dispatchDidNavigateWithinPage() after calling checkComplete() and checkLoadComplete().  By moving the dispatchDidNavigateWithinPage() call earlier, we still have m_previousItem when the content state is updated.  This fixes the issue with fragment navigations entirely.

I've double checked that the behavior of Chromium's FrameLoaderClientImpl::dispatchDidNavigateWithinPage() is the same whether we call it before or after checkComplete().  I'm running the layout tests now to be sure.  Patch on the way-- it's nice and simple, since we don't need to keep track of lastCommittedItem separately anymore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.