[Webkit-unassigned] [Bug 49341] REGRESSION: Select combo-box not displayed

Thu Nov 11 11:07:33 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=49341

--- Comment #5 from Robert Hogan <robert at webkit.org>  2010-11-11 11:07:33 PST ---

Eric, thanks for pointing me to those. The patch fixes two current failures:

resources/tests7.dat: fixes 30
resources/tests19.dat: fixes 63

It creates the following new failures. I've added comments to each.

Test 30 of 115 in resources/tests1.dat failed. Input:
<select><b><option><select><option></b></select>X
Got:
| <html>
|   <head>
|   <body>
|     <select>
|       <option>
|     "X"
Expected:
| <html>
|   <head>
|   <body>
|     <select>
|       <option>
|     <option>
|       "X"

Given the errors expected from this test:

Line: 1 Col: 8 Unexpected start tag (select). Expected DOCTYPE.
Line: 1 Col: 11 Unexpected start tag token (b) in the select phase. Ignored.
Line: 1 Col: 27 Unexpected select start tag in the select phase treated as select end tag.
Line: 1 Col: 39 End tag (b) violates step 1, paragraph 1 of the adoption agency algorithm.
Line: 1 Col: 48 Unexpected end tag (select). Ignored.
Line: 1 Col: 49 Expected closing tag. Unexpected end of file.

the expected markup seems wrong to me, and the new markup seems right.

Test 35 of 115 in resources/tests1.dat failed. Input:
<!DOCTYPE html>A<option>B<optgroup>C<select>D</option>E
Got:
| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     "ABC"
|     <select>
|       "DE"
Expected:
| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     "A"
|     <option>
|       "B"
|     <optgroup>
|       "C"
|       <select>
|         "DE"

Again, were the expectations correct here?

Test 103 of 115 in resources/tests1.dat failed. Input:
<select><b><option><select><option></b></select>
Got:
| <html>
|   <head>
|   <body>
|     <select>
|       <option>
Expected:
| <html>
|   <head>
|   <body>
|     <select>
|       <option>
|     <option>

The illegal option element gets dropped. Simiar to 30 above.

Test 36 of 61 in resources/tests2.dat failed. Input:
<!DOCTYPE html><select><optgroup><option></optgroup><option><select><option>
Got:
| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <select>
|       <optgroup>
|         <option>
|       <option>
Expected:
| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <select>
|       <optgroup>
|         <option>
|       <option>
|     <option>

This is the same as test 30 above.

Test 38 of 61 in resources/tests2.dat failed. Input:
<!DOCTYPE html><datalist><option>foo</datalist>bar
Got:
| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <datalist>
|       "foo"
|     "bar"
Expected:
| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <datalist>
|       <option>
|         "foo"
|     "bar"

I'm updating the patch to allow datalist and optgroup contexts for the option element. That should fix this error.

resources/tests7.dat: fixes 30
resources/tests19.dat: fixes 63

resources/webkit01.dat:
29

Test 29 of 47 in resources/webkit01.dat failed. Input:
<select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>
Got:
| <html>
|   <head>
|   <body>
|     <select>
|       <option>
|         "A"
|     "B"
|     <select>
|       <option>
|         "C"
|     "D"
|     <select>
|       <option>
|         "E"
|     "F"
|     <select>
|       <option>
|         "G"
Expected:
| <html>
|   <head>
|   <body>
|     <select>
|       <option>
|         "A"
|     <option>
|       "B"
|       <select>
|         <option>
|           "C"
|     <option>
|       "D"
|       <select>
|         <option>
|           "E"
|     <option>
|       "F"
|       <select>
|         <option>
|           "G"

Again <option> outside select is getting dropped.

Before I submit, do these new results look right to you?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.