[Webkit-unassigned] [Bug 49018] [GTK] response.isNull() assert when using directory file URI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49018





--- Comment #25 from Sergio Villar Senin <svillar at igalia.com>  2010-11-11 06:49:12 PST ---
(In reply to comment #24)
> (In reply to comment #23)
> > (In reply to comment #22)
> > > Created an attachment (id=73535)
 --> (https://bugs.webkit.org/attachment.cgi?id=73535&action=review) [details] [details] [details]
> > > Fix assert using directory file URI
> > > 
> > > Updated patch.
> > 
> > The patch looks good to me, don't know if we need such amount of new asserts tough :). Being a bit picky I wouldn't say "Ensure a response for protocol using GIO.", we're ensuring it for any protocol not directly handled by WebKitGtk+, it could be gio, libsoup or whatever.
> 
> All the asserts have been triggered once by at least one test. The numerous assert is just an indicator of how spaghetti is that code ;)
> 
> I was doing generic stuff and you guys complained, so I've did it for what exist, and in this case soup and data was working, so I only fixed GIO (nothing else exist atm).
> 
> > 
> > And regarding the comment in the ChangeLog I suggest something more descriptive like:
> > "Do ensure that didReceiveResponse happens before any call to didReceiveData. That was not true for file: URIs pointing to directories and thus was triggering an assertion." I think that's a bit better because your patch is really fixing that instead of only the directory issue mentioned in the bug. Just my 2 cents.
> 
> No, it was working for normal files, only directories where affected. FTP and FTPs always do errors (not mounted error), so they are not affected.

"That was not true for file: URIs pointing to directories" I didn't mention normal files at all.

> Just want to leave a note that it gets really frustrating when reviews are being done 1 line at the time. Please, consider doing full review next time, you'll save time and I'll save time too.

I have learned several things since I'm a webkitter, and one of them is that the review process could take some time, but it works, and it ensures that the project moves forward. We're part of a bigger project and entering in such a big community requires to accept some rules.

I'm not a reviewer yet, but if you want to work in webkit my advice would be that you should be more patient, as reviewers are very busy guys that have to do a lot of things and ensure that the quality of the contributions meets webkit requirements.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.