[Webkit-unassigned] [Bug 49259] Rename GeolocationControllerClient to GeolocationClient
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 11 04:19:34 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=49259
--- Comment #3 from Steve Block <steveblock at google.com> 2010-11-11 04:19:35 PST ---
(From update of attachment 73474)
View in context: https://bugs.webkit.org/attachment.cgi?id=73474&action=review
Sounds good to me. InspectorController/InspectorClient also follows this pattern. The only other example I can see of the other style is BackForwardController/BackForwardControllerClient.
This patch appears to be missing the change to GeolocationClient.h/cpp?
Also, it looks like you might need to rebase for win before landing.
> WebKit/mac/WebView/WebView.mm:710
> + pageClients.geolocationControllerClient = new WebGeolocationClient(self);
Can you fix up PageClients to reflect the new name?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list