[Webkit-unassigned] [Bug 49240] Implement formaction, formenctype, formmethod and formtarget attributes for the input tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49240





--- Comment #7 from Kent Tamura <tkent at chromium.org>  2010-11-10 22:18:32 PST ---
(In reply to comment #5)
> >> WebCore/html/HTMLFormElement.cpp:330
> >> +    }
> > 
> > This whole thing looks like it should just live in FormSubmission::create.
> 
> I guess it should be handled here for the same reason as copyFrom() below.
> 
> >> WebCore/loader/FormSubmission.cpp:121
> >> +
> > 
> > And this becomes unnecessary.
> 
> Copying is still required. Values of attributes form* (like formaction) must be parsed by parser methods (like FormSubmission::Attributes::parseAction()). But HTMLFormElement::m_attribute should not be modified.

I understand the requirement of copyFrom(), but we can move the HTMLFormElement.cpp change to FormSubmission.cpp because FormSubmission::create() knows all of necessary information.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.