[Webkit-unassigned] [Bug 49353] ComplexTextController not prepared to handle multiple runs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 10 21:00:27 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49353





--- Comment #3 from nholbrook at apple.com  2010-11-10 21:00:28 PST ---
(In reply to comment #2)
> (From update of attachment 73555 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73555&action=review
> 
> Wow, the code was totally wrong. I said r+ but I think there’s room for improvement.

I'm happy to make the changes you suggested, give me a minute to prepare a new patch.

> > WebCore/platform/graphics/mac/ComplexTextController.h:167
> > +    const int m_end;
> 
> Huh? I can’t cq+ because of this.

Is it against WebKit style to make immutable member variables const? It was purely a defensive change, but I'll back it out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list