[Webkit-unassigned] [Bug 22759] dropdown menu disappears on mouse-over

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 10 19:04:58 PST 2010


--- Comment #6 from dgrogan at google.com  2010-11-10 19:04:58 PST ---
(From update of attachment 73438)
View in context: https://bugs.webkit.org/attachment.cgi?id=73438&action=review

>> WebCore/css/CSSPrimitiveValue.h:46
>> +    value += (value < 0) ? -0.5 : +0.5;
> I’m pretty sure this is not acceptable. We discussed this when originally writing the code here and tried it and saw problems. Did you run regression tests? What tests did this affect?
> By the way, if we *do* want this rounding, then I think we want to use the appropriate rounding function, roundf or round, rather than rolling our own with +=.

There were ~170 unexpected failures.  Most fail because of pixel differences unrelated to the tests' substance or are improvements on the existing results.  Two failing tests were on point though: svg/custom/fractional-rects and fast/dom/length-attribute-mapping.  They both expect lengths specified as floats to be rounded down.  Firefox seems to agree with them.

I'm going to work on this a bit more to get those two tests to pass along with the one I'm introducing here.  Thanks for the feedback.

On round(f): agreed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list