[Webkit-unassigned] [Bug 49329] Do not allow access to session and local storage when in private browsing mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49329


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73561|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2010-11-10 17:35:25 PST ---
(From update of attachment 73561)
View in context: https://bugs.webkit.org/attachment.cgi?id=73561&action=review

> WebCore/storage/Storage.cpp:59
> -    if (!m_frame)
> +    if (!m_frame || m_frame->page()->settings()->privateBrowsingEnabled())

We need to null-check page too. It’s possible for a frame to outlive its page and thus have 0 for a page. But settings is guaranteed to be non-zero for any page.

Sorry, I missed that earlier.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.