[Webkit-unassigned] [Bug 49018] [GTK] response.isNull() assert when using directory file URI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49018


Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73407|0                           |1
        is obsolete|                            |




--- Comment #22 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2010-11-10 13:51:55 PST ---
Created an attachment (id=73535)
 --> (https://bugs.webkit.org/attachment.cgi?id=73535&action=review)
Fix assert using directory file URI

Updated patch.

Code:
- Added more assert()
- Moved readCallback() assert lower since sending a response is not required if read failed.
- Use d->m_response for data:// to avoid asserting on !d->m_response.isNull() later
- Using handle->shouldContentSniff() along with d->m_response.isNull() to decide if a response should be sent in sendRequestCallback()

Test:
- renamed test to crash-display-local-directory.html
- Creating iframe in HTML and not using JS
- Using iframe onload() instead of body onload()
- Using <p> instead of <div> and <br/>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.