[Webkit-unassigned] [Bug 49315] chrome.dll!WebCore::ApplyStyleCommand::surroundNodeRangeWithElement ReadAV at NULL (d21e8ab8aa42253ec7e46b595e4cf4fd)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49315





--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2010-11-10 13:51:08 PST ---
Making the following change in unlistifyParagraph will fix my reduction:

-    VisiblePosition insertionPoint = VisiblePosition(Position(placeholder.get(), 0));
+    VisiblePosition insertionPoint = VisiblePosition(positionAfterNode(placeholder.get()));
+
+    // insertPoint has collapsed; i.e. it's the end of line perhaps because li & ol had display: inline
+    if (endOfParagraph(insertionPoint) == endOfParagraph(end)) {
+        placeholder = createBreakElement(document());
+        insertNodeAfter(placeholder, nodeToInsert);
+        insertionPoint = VisiblePosition(Position(placeholder.get(), 0));
+        ASSERT(endOfParagraph(insertionPoint) != endOfParagraph(end));
+    }
+

However, reproduction 2 (infinite loop case) still crashes and fixing this second crash requires overhaul of many editing functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.