[Webkit-unassigned] [Bug 49333] simplify png decoding loop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49333


Peter Kasting <pkasting at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73520|review?                     |review-
               Flag|                            |




--- Comment #1 from Peter Kasting <pkasting at google.com>  2010-11-10 12:01:01 PST ---
(From update of attachment 73520)
This isn't quite right.  If row 0 has alpha and row 1 does not, you'll setHasAlpha(true) on the first row and (false) on the second.

Instead you should probably do:

if (nonTrivialAlpha)
    buffer.setHasAlpha(true);

...at the end.

It would be good to add a pixel test with a png that exercises this particular case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.