[Webkit-unassigned] [Bug 49285] [Chromium/DRT] Make EventSendingController send complete touch events.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 10 11:59:21 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49285


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73505|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from James Robinson <jamesr at chromium.org>  2010-11-10 11:59:21 PST ---
(From update of attachment 73505)
View in context: https://bugs.webkit.org/attachment.cgi?id=73505&action=review

Patch looks good, but please fix/remove the comment before landing.

> WebKitTools/DumpRenderTree/chromium/EventSender.cpp:878
> +    // Force a layout here just to make sure every position has been
> +    // determined before we send events (as well as all the other methods
> +    // that send an event do).

This comment doesn't seem very helpful, I'd just leave it out.  It's also not entirely accurate from what I can tell (it won't change the position argument passed on this event).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list