[Webkit-unassigned] [Bug 49306] Fix autofill popup height computation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49306





--- Comment #7 from Ilya Sherman <isherman at chromium.org>  2010-11-10 02:00:18 PST ---
(In reply to comment #4)
> (From update of attachment 73467 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73467&action=review
> 
> It's nice if we can add a test (maybe manual test, unfortunately) for this change.

AFAIK this code is used only be Chromium autofill, and there is no good way to add a test for this from within WebKit -- even a manual one.  Eventually I'd like to add a way to test this popup more generally, but that's outside the scope of this patch.

> 
> > WebCore/platform/chromium/PopupMenuChromium.cpp:1301
> > +    int y = 0;
> 
> I think we can just reuse windowHeight and we don't need this variable?

Good call =)

> > WebCore/platform/chromium/PopupMenuChromium.cpp:1307
> > +        y += rowHeight;
> 
> Could you check if this test http://trac.webkit.org/browser/trunk/WebCore/manual-tests/display-none-option.html?rev=71727 still works?

Seems to work -- pretty sure the <select> popup is independent of this code.

> I guess we need
> 
> if (!m_popupClient->itemStyle(i).isDisplayNone())
> 
> here.

This is handled internally to getRowHeight().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.