[Webkit-unassigned] [Bug 49306] Fix autofill popup height computation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49306


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73467|                            |review-
               Flag|                            |




--- Comment #4 from Shinichiro Hamaji <hamaji at chromium.org>  2010-11-10 01:16:11 PST ---
(From update of attachment 73467)
View in context: https://bugs.webkit.org/attachment.cgi?id=73467&action=review

It's nice if we can add a test (maybe manual test, unfortunately) for this change.

> WebCore/platform/chromium/PopupMenuChromium.cpp:1301
> +    int y = 0;

I think we can just reuse windowHeight and we don't need this variable?

> WebCore/platform/chromium/PopupMenuChromium.cpp:1307
> +        y += rowHeight;

Could you check if this test http://trac.webkit.org/browser/trunk/WebCore/manual-tests/display-none-option.html?rev=71727 still works? I guess we need

if (!m_popupClient->itemStyle(i).isDisplayNone())

here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.