[Webkit-unassigned] [Bug 49289] [chromium] menu key doesn't work when capslock or numslock is on

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49289





--- Comment #4 from Evan Stade <estade at chromium.org>  2010-11-09 18:16:30 PST ---
(From update of attachment 73443)
View in context: https://bugs.webkit.org/attachment.cgi?id=73443&action=review

>> WebKit/chromium/public/WebInputEvent.h:133
>> +    static const int InputModifiers = ShiftKey | ControlKey | AltKey | MetaKey;
> 
> Nit: I don't like this name much.  Aren't capslock and numlock also input modifiers?  Should there just be a static method that returns event.modifiers & (ShiftKey | ControlKey | AltKey | MetaKey) like the other methods?

I can't think of a better name (really the best name is "modifier", but the enum took that already). I got this name from the getWebInputModifiers() function in WebInputEventConversion.cpp

I think it's more versatile as a bitmask but if you would rather it be an applied bitmask I can do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.