[Webkit-unassigned] [Bug 22759] dropdown menu disappears on mouse-over

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22759





--- Comment #5 from Darin Adler <darin at apple.com>  2010-11-09 17:33:25 PST ---
(From update of attachment 73438)
View in context: https://bugs.webkit.org/attachment.cgi?id=73438&action=review

> WebCore/css/CSSPrimitiveValue.h:46
> -    value += (value < 0) ? -0.01 : +0.01;
> +    value += (value < 0) ? -0.5 : +0.5;

I’m pretty sure this is not acceptable. We discussed this when originally writing the code here and tried it and saw problems. Did you run regression tests? What tests did this affect?

By the way, if we *do* want this rounding, then I think we want to use the appropriate rounding function, roundf or round, rather than rolling our own with +=.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.