[Webkit-unassigned] [Bug 23432] window.open scripts do not trigger newWindowDelegate callback.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 9 14:22:40 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=23432


Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73417|                            |review?
               Flag|                            |




--- Comment #10 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2010-11-09 14:22:40 PST ---
Created an attachment (id=73417)
 --> (https://bugs.webkit.org/attachment.cgi?id=73417&action=review)
[PATCH 3/4] Don't duplicate code from FrameTree::find()

In JSDOMWindow::open() we duplicate some of the code from
FrameTree::find(). This patch also removes one call to FrameTree::find().
This code cleanup is attached to this bug since it ensure that createWindow
is actually called to create new window, reducing side effect risk.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list