[Webkit-unassigned] [Bug 48809] Chromium WebKit API needs WebFrame::lastCommittedHistoryItem()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 9 12:17:39 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=48809
--- Comment #20 from Charles Reis <creis at chromium.org> 2010-11-09 12:17:39 PST ---
(In reply to comment #19)
> I can't think of any good reason for nulling out m_previousItem. Does anything actually break (layout test wise) if you make HistoryController::updateForFrameLoadCompleted() do nothing? The comment in that function seems out-of-date. It seems like the kind of thing that m_provisionalItem resolves.
Yep, that breaks forward fragment navigations (in both Chrome and test_shell). Plus it introduces a crash in certain cases because of an ASSERT(!m_previousItem) in HistoryController::recursiveGoToItem on line 567. Disabling the assert still leaves the problem with forward navigations.
It's too bad these files aren't better commented, because it's not clear what values m_previousItem is expected to have at various points in time. There seem to be a lot of assumptions that it is null between navigations rather than pointing to the last committed item, though.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list