[Webkit-unassigned] [Bug 23432] window.open scripts do not trigger newWindowDelegate callback.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23432





--- Comment #7 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2010-11-09 08:52:59 PST ---
After more work on this I've finally managed to implement a solution that I will soon attach. The solution I've found is to allow creating page without making it visible (see Page::chrome().show() and WebCore::createWindow()). This enables two things: 1) you can actually request for location change before displaying the window, which allow making popup blocking decision/triage based on URI before the window is displayed and 2) for synchronous scripted popup (e.g. window.open()), you can simply create an hidden window, fire NewWindowPolicy on initial location change and show only if decision was positive (close if not).

At first I was concern about show() call being flipped with ChangeLocationPolicy, but I found that there exist cases where we already get this order. Stay tunned ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.