[Webkit-unassigned] [Bug 44256] [EFL] Private Browsing feature for WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44256





--- Comment #22 from Grzegorz <g.czajkowski at samsung.com>  2010-11-09 06:39:21 PST ---
(In reply to comment #20)
> (In reply to comment #19)
> > Created an attachment (id=73220)
 --> (https://bugs.webkit.org/attachment.cgi?id=73220&action=review) [details] [details]
> > Incognito feature for WebKit-Efl
> > 
> > Alphabetical sorting problem has been resolved.
> > I am sorry for the previous comments :)
> 
> About the last patch:
> 
> +        Saves cookies to a new cookie jar, disables cache of WebCore and doesn't strore any pages for offline use.
> 
> Please, fix the typo ("strore").

Fixed. I am sorry for the misprints.

> 
> + * @param enable if @c EINA_TRUE creates a new cookie jar (all cookies will be saved to this one), c@ EINA_FALSE restores default cookie jar.
> 
> Another typo ("c@" instead of "@c").

Fixed

> 
> + * @return @ EINA_TRUE if cookie jar has been replaced/restored. @c EINA_FALSE otherwise or other error occured.
> 
> Another typo ("@" between return and EINA_TRUE shouldn't exist).

Fixed

> 
> Other comments:
> 
> Could you change the name _ewk_cookie_jar_replace() to _ewk_cookie_jar_replace_set()? Or even something like _ewk_cookie_jar_fake_set(), or _ewk_cookie_jar_tmp_set()? Maybe it's just my opinion, but I believe that this is a little more descriptive...
> 

That's a good idea. I changed it to _ewk_cookie_jar_fake_set().

> I also believe that a better place for the function _ewk_cache_disable would be inside ewk_settings.cpp. What do you think about it?
> 

Ok. I moved it and changed name to ewk_setting_disable_cache_set and exported it to public API.

>
> Regards,
> 
> Rafael

I added comments to functions _ewk_incognito_cookie_get and _ewk_cookie_jar_fake_set that they aren't exported to public API.

I've fixed the build break because a file Cache.h has been renamed to MemoryCache.h.

I did a small changes in ewk_setting.cpp regarding to sorting problems of includes files. I hope that you don't mind on that :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.