[Webkit-unassigned] [Bug 45443] [GTK] Support for viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45443


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73192|review?                     |review-
               Flag|                            |




--- Comment #54 from Gustavo Noronha (kov) <gns at gnome.org>  2010-11-09 04:33:02 PST ---
(From update of attachment 73192)
View in context: https://bugs.webkit.org/attachment.cgi?id=73192&action=review

> WebKit/gtk/webkit/webkitviewportattributes.cpp:301
> + */
> +void webkit_viewport_attributes_recompute(WebKitWebView* webView)
> +{
> +    g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
> +
> +    GdkScreen* screen = gtk_widget_get_screen(GTK_WIDGET(webView));
> +    FloatRect rect = webView->priv->corePage->chrome()->pageRect();
> +    ViewportArguments arguments = webView->priv->corePage->mainFrame()->document()->viewportArguments();
> +    // The DesktopWidth has 980, because this value works well for most web pages designed for desktop user agents.
> +    ViewportAttributes attrs = computeViewportAttributes(arguments, 980, gdk_screen_get_width(screen), gdk_screen_get_height(screen), webkit_web_view_get_dpi(webView), IntSize(static_cast<gint>(rect.width()), static_cast<gint>(rect.height())));
> +    PlatformRefPtr<WebKitViewportAttributes> viewportAttributes(adoptPlatformRef(webkit_viewport_attributes_new(attrs, arguments.userScalable)));
> +
> +    g_signal_emit_by_name(webView, "viewport-attributes-changed", viewportAttributes.get()); 

I still don't understand your choice of only firing the signal after you have computed the values. Can you describe to me how you would use this API in a browser?

> WebKit/gtk/webkit/webkitviewportattributes.h:58
> +WEBKIT_API void 
> +webkit_viewport_attributes_recompute                (WebKitWebView* webView); 

This should take a WebKitViewPort as the argument, not a web view.

> WebKit/gtk/webkit/webkitwebview.cpp:1394
> -static gdouble webViewGetDPI(WebKitWebView* webView)
> +gdouble webkit_web_view_get_dpi(WebKitWebView* webView)

I suggest keeping the name, using GTK+ style for non-API stuff is actually discouraged (despite it being everywhere =().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.