[Webkit-unassigned] [Bug 49200] [Qt] bugs in Composition mode for QWebPage::inputMethodEvent & inputMethodQuery()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49200


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73271|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Andreas Kling <kling at webkit.org>  2010-11-09 00:40:36 PST ---
(From update of attachment 73271)
View in context: https://bugs.webkit.org/attachment.cgi?id=73271&action=review

Very nice test coverage here!
Unfortunately I have to r- because of lacking ChangeLog.

> WebKit/qt/ChangeLog:7
> +

Insufficient ChangeLog- please explain what's being changed and why.

> WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1695
> +    // clear selection, also cancel the ongoing composition if there is one

Comments should be capitalized and end with a period.

> WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1704
> +    //ImCurrentSelection

Style violation, space after //

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.