[Webkit-unassigned] [Bug 49208] Build fails when features are disabled (--disable-database, --disable-svg, etc.)

Mon Nov 8 22:32:22 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=49208

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2010-11-08 22:32:22 PST ---
(From update of attachment 73284)
>-#include "JSSQLStatementErrorCallback.h"
> 
>#if ENABLE(DATABASE)
>
>+#include "JSSQLStatementErrorCallback.h"

This is not the right way to fix this. Preprocessor guards should be in header files, so that one doesn't need to to at extra lengths in .cpp files. That also means that generated header files need to be generated even for disabled features.

Not marking r-, because changing derived files generator is somewhat more challenging, but please consider fixing this the right way. And yes, there is quite a bit of precedent for preprocessor guards being in .cpp, unfortunately.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.