[Webkit-unassigned] [Bug 48308] Too precise serialization from floating point number to string for "number" input elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48308


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73333|review?                     |review+
               Flag|                            |




--- Comment #39 from Gavin Barraclough <barraclough at apple.com>  2010-11-08 19:11:24 PST ---
(From update of attachment 73333)
The patch looks great to me, setting r+ based on Kent's last comment.  

> I see. It's an issue to be considered, I think. I've created another bug since it's a different issue from the bug 48308.
> https://bugs.webkit.org/show_bug.cgi?id=48976
> 
> For short, I guess it's not an issue of min/max checks, but an issue on general steps from values in step-mismatching state.
> As written in the bug 48976, for the case <input type="number" step="1" min="0" max="10.9" value="8.7" /> then stepUp(), I think the result should be 9 rather than 10. May I ask your opinion?

Dealing with the step mismatch as a separate bug seems sensible, re the change in behavior, I'm not sure I have much of an opinion on this – it's quite a way from my area of expertise – but your proposed change certainly sounds right to me, seems intuitively like better behavior for stepUp to always take you to the next step, never the next-but-one.

cheers,
G.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.