[Webkit-unassigned] [Bug 34660] audio engine: add audio resources abstraction

Mon Nov 8 17:02:59 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=34660

Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73144|review?                     |review-
               Flag|                            |

--- Comment #13 from Kenneth Russell <kbr at google.com>  2010-11-08 17:02:59 PST ---
(From update of attachment 73144)
View in context: https://bugs.webkit.org/attachment.cgi?id=73144&action=review

The code basically looks fine. r- for the license header issue as well as a couple of other minor issues.

> WebCore/platform/audio/mac/AudioBusMac.mm:15
> + *     from this software without specific prior written permission.

Wrong license header.

> WebCore/platform/audio/mac/AudioBusMac.mm:40
> + at interface WebCoreBundleClass : NSObject

I think it would be safer to name this temporary class something audio-specific like WebCoreAudioBundleClass.

> WebCore/platform/audio/mac/AudioBusMac.mm:68
> +} // WebCore

// namespace WebCore

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.