[Webkit-unassigned] [Bug 49018] [GTK] response.isNull() assert when using directory file URI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49018





--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2010-11-08 13:18:46 PST ---
(In reply to comment #7)

> > > WebCore/platform/network/soup/ResourceHandleSoup.cpp:-699
> > > -    if (equalIgnoringCase(protocol, "file") || equalIgnoringCase(protocol, "ftp") || equalIgnoringCase(protocol, "ftps")) {
> > 
> > If I am not wrong, this has nothing to do with the bug so, I guess you either should attach another patch or maybe a different bug, Martin?
> 
> I'll let Martin reply, normally I would split this up in a git branch, but WebKit process with ChangeLog is such a *** that I prefer keep related one liner together.

Unrelated bug fixes should be in separate bugs and patches. Additionally, each patch should, if possible, include tests for that change (and especially changes in WebCore). In some cases there is no sane way to test a change, this should probably be outlined in the ChangeLog. The webkit-patch tool makes working with ChangeLogs and patches a lot easier. Definitely look into that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.