[Webkit-unassigned] [Bug 44256] [EFL] Private Browsing feature for WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44256





--- Comment #20 from Rafael Antognolli <antognolli at profusion.mobi>  2010-11-08 10:25:53 PST ---
(In reply to comment #19)
> Created an attachment (id=73220)
 --> (https://bugs.webkit.org/attachment.cgi?id=73220&action=review) [details]
> Incognito feature for WebKit-Efl
> 
> Alphabetical sorting problem has been resolved.
> I am sorry for the previous comments :)

About the last patch:

+        Saves cookies to a new cookie jar, disables cache of WebCore and doesn't strore any pages for offline use.

Please, fix the typo ("strore").

+ * @param enable if @c EINA_TRUE creates a new cookie jar (all cookies will be saved to this one), c@ EINA_FALSE restores default cookie jar.

Another typo ("c@" instead of "@c").

+ * @return @ EINA_TRUE if cookie jar has been replaced/restored. @c EINA_FALSE otherwise or other error occured.

Another typo ("@" between return and EINA_TRUE shouldn't exist).

Other comments:

Could you change the name _ewk_cookie_jar_replace() to _ewk_cookie_jar_replace_set()? Or even something like _ewk_cookie_jar_fake_set(), or _ewk_cookie_jar_tmp_set()? Maybe it's just my opinion, but I believe that this is a little more descriptive...

I also believe that a better place for the function _ewk_cache_disable would be inside ewk_settings.cpp. What do you think about it?

Regards,

Rafael

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.