[Webkit-unassigned] [Bug 47817] FrameLoader::IsProcessingUserGesture is true for JavaScript initiated downloads after click navigation to webpage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47817





--- Comment #35 from Johnny Ding <jnd at chromium.org>  2010-11-08 10:10:57 PST ---
(In reply to comment #34)
Thanks, Alexey!
> The bug doesn't really have more detail. It sort of kind of makes sense, but there is no concrete explanation or problem example in the bug.
> 
>  I don't know what's the use of checking for user gesture when downloading, so I can't tell what the benefit of making the indication more precise is.

I thought Pierre-Antoine LaFayette's #1 comment might explain this issue. Anyway, I gonna change the explanation in test case to the following contents. @Pierre-Antoine LaFayette, can you also review it to see whether it explains this bug? Thanks!

Some WebKit ports send the user gesture to the embedders in didStartProvisionalLoad callback. The embedders use it to judge the navigation is user-initiated or not. In mete refresh redirection, the user gesture status in didStartProvisionalLoad callback should be false. 
For more details, please refer to https://bugs.webkit.org/show_bug.cgi?id=47817.

> These are not correct bug numbers. Bug in Skipped list comment should be tracking a failure or missing DumpRenderTree feature. If there is no tracking bug, a comment should explain the failure.

I change the comment to the following explanation.

# The following tests requires the DRT's dumpUserGestureInFrameLoadCallbacks
# method. But that method is not implemented in gtk port since gtk port can't
# get user gesture in frameload callbacks.
# The related bugs are https://bugs.webkit.org/show_bug.cgi?id=47849/47817.

Rebasing the patch, upload soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.