[Webkit-unassigned] [Bug 49168] New: [WML] Fix build breaks when WML is enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 04:11:35 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49168

           Summary: [WML] Fix build breaks when WML is enabled
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: gyuyoung.kim at samsung.com


There are two build breaks when WML is enabled.

The backForward() of Page class returns BackForwarddController class type. So, WML classes need to include the BackForwardController.h file. And, select() of RenderTextControl.h was removed. Thus, the select() should be replaced by setSelectionRange().

=================================================================================================================================
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLDocument.cpp: In member function ‘virtual void WebCore::WMLDocument::finishedParsing()’:
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLDocument.cpp:71: error: invalid use of incomplete type ‘struct WebCore::BackForwardController’
/home/gyuyoung/webkit/WebKit-git/WebCore/page/Page.h:41: error: forward declaration of ‘struct WebCore::BackForwardController’
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLDoElement.cpp: In member function ‘virtual void WebCore::WMLDoElement::defaultEventHandler(WebCore::Event*)’:
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLDoElement.cpp:93: error: invalid use of incomplete type ‘struct WebCore::BackForwardController’
/home/gyuyoung/webkit/WebKit-git/WebCore/page/Page.h:41: error: forward declaration of ‘struct WebCore::BackForwardController’
make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLDocument.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLDoElement.cpp.o] Error 1
make[1]: *** [WebCore/CMakeFiles/webcore_efl.dir/all] Error 2
make: *** [all] Error 2


/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp: In member function ‘virtual void WebCore::WMLInputElement::select()’:
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp:194: error: ‘class WebCore::RenderTextControl’ has no member named ‘select’
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp: In member function ‘void WebCore::WMLInputElement::initialize()’:
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp:377: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp: In member function ‘WTF::String WebCore::WMLInputElement::validateInputMask(const WTF::String&)’:
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp:392: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp:396: warning: comparison between signed and unsigned integer expressions
=================================================================================================================================

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list