[Webkit-unassigned] [Bug 49112] Fix 32-bit vs. 64-bit Accelerate.framework issues in VectorMath

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 00:43:06 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49112


Maciej Stachowiak <mjs at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73139|review?                     |review-
               Flag|                            |




--- Comment #2 from Maciej Stachowiak <mjs at apple.com>  2010-11-08 00:43:05 PST ---
(From update of attachment 73139)
View in context: https://bugs.webkit.org/attachment.cgi?id=73139&action=review

What is the effect of this patch? Does the current code fail to build on 32-bit, or does it build but behave differently when changed this way? Is there a reason we can't use the same code path for both 32-bit and 64-bit platforms?

Also of note: ARM is a 32-bit platform not covered by your macros. Is it ok for it to go down the same code path as 64-bit? I think either your macro test is wrong (if ARM should be included with 32-bit)) or the ChangeLog is wrong (if the issue is specific to just i386 and ppc, rather than all 32-bit platforms).

> WebCore/platform/audio/VectorMath.cpp:41
> +// In 32-bit mode __ppc__ or __i386__ is defined and <vecLib/vDSP_translate.h> is included which defines macros, so we must handle this case differently.

This comment does not seem useful. It says the 32-bit case is handled differently, but does not say why.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list