[Webkit-unassigned] [Bug 25679] [GTK] Improve accessibility of focusable lists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25679


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72945|review?                     |review-
               Flag|                            |




--- Comment #27 from chris fleizach <cfleizach at apple.com>  2010-11-07 23:20:06 PST ---
(From update of attachment 72945)
View in context: https://bugs.webkit.org/attachment.cgi?id=72945&action=review

> WebCore/ChangeLog:14
> +        'focus-event', along with apropriate detail along with each of

spelling -> apropriate

> WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:55
> +    AccessibilityRenderObject::AccessibilityChildrenVector items = object->children();

this should be AccessibilityObject::AXChildrenVector

> WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:56
> +    SelectElement* select = toSelectElement(static_cast<Element*>(object->node()));

you should check if select == 0 after this line

> WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:58
> +    if (changedItemIndex < 0 || changedItemIndex >= (int)items.size())

use static cast here

> WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:65
> +    static RefPtr<AccessibilityObject> oldFocusedObject;

this static should be at the top of the method. i also believe there's a standard way to initialize statics, that you should look for

> WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:83
> +        g_signal_emit_by_name(axItem, "focus-event", isSelected);

do you want to emit focus-event every time this happens? or do you want to limit it to when axItem != oldFocusedItem

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.