[Webkit-unassigned] [Bug 48255] Stack overflow when there are too many sibling inline boxes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 7 20:07:35 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=48255


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72703|review?                     |review-
               Flag|                            |




--- Comment #5 from Andreas Kling <kling at webkit.org>  2010-11-07 20:07:35 PST ---
(From update of attachment 72703)
View in context: https://bugs.webkit.org/attachment.cgi?id=72703&action=review

> WebCore/rendering/InlineBox.h:165
> -    virtual void setConstructed()
> -    {
> -        m_constructed = true;
> -        if (m_next)
> -            m_next->setConstructed();
> -    }
> +    virtual void setConstructed() { m_constructed = true; }

This looks like a behavior change to me, InlineBox::setConstructed() will no longer affect sibling boxes.
Is this correct (and safe)?

> WebCore/rendering/InlineBox.h:284
> +    InlineBox* next() { return m_next; }

This method should be const.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list