[Webkit-unassigned] [Bug 49136] [GTK] Wrapped DOM bindings GObjects do not disconnect event listeners when they die

Sat Nov 6 20:07:56 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=49136

Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73182|review?                     |review+
               Flag|                            |

--- Comment #2 from Xan Lopez <xan.lopez at gmail.com>  2010-11-06 20:07:56 PST ---
(From update of attachment 73182)
View in context: https://bugs.webkit.org/attachment.cgi?id=73182&action=review

Looks good to me.

> WebCore/bindings/gobject/GObjectEventListener.cpp:46
> +        m_coreNode->addEventListener(domEventName, this, false);

There's no way you can have both right? There should be an else.

> WebCore/bindings/gobject/GObjectEventListener.h:51
> +

This should probably go in the impl. file?

> WebCore/bindings/gobject/GObjectEventListener.h:71
> +    // we only use them when the GObject and thus the WebCore object is alive.

when the GObject... is created?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.