[Webkit-unassigned] [Bug 46335] Add EditingStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46335





--- Comment #20 from Ryosuke Niwa <rniwa at webkit.org>  2010-11-06 13:30:50 PST ---
Thanks for the review as always!

(In reply to comment #19)
> > WebCore/editing/EditingStyle.cpp:118
> > +    m_mutableStyle = 0;
> 
> Should be nullptr rather than 0.

Used clear() instead.

> Typo: "edting style".

Fixed.

> To me it seems unhelpful to have EditingStyle be a reference counted object. Since an editing style contains just one pointer to a reference counted object and one boolean, it seems it could instead be a normal copyable object with constructors instead of create functions. This would make it easier to program with.

I wrote in comment #1 as well but I have a plan to merge StyleChange and conversion table between CSS & html elements in ApplyStyleCommand.cpp to this class.  So I suspect that it'll have more member variables and definitely more member functions.  I also wanted to make the transition from CSSMutableStyleDeclaration to EditingStyle easy, and since CSSMutableStyleDeclaration is a reference counted object, I made EditingStyle a reference counted object as well to make reviewing process easier.  However, I'm happy to change it to a normal object once I migrated the other parts of editing code to use EditingStyle, and we concluded that reference counting is unnecessary.

> Typo: "strole colors"

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.