[Webkit-unassigned] [Bug 46335] Add EditingStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46335


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73014|review?                     |review+
               Flag|                            |




--- Comment #19 from Darin Adler <darin at apple.com>  2010-11-06 09:38:23 PST ---
(From update of attachment 73014)
View in context: https://bugs.webkit.org/attachment.cgi?id=73014&action=review

> WebCore/editing/EditingStyle.cpp:118
> +    m_mutableStyle = 0;

Should be nullptr rather than 0.

> WebCore/editing/EditingStyle.cpp:149
> +    RefPtr<EditingStyle> edtingStyle = EditingStyle::create(position);

Typo: "edting style".

> WebCore/editing/EditingStyle.h:43
> +class EditingStyle : public RefCounted<EditingStyle> {

To me it seems unhelpful to have EditingStyle be a reference counted object. Since an editing style contains just one pointer to a reference counted object and one boolean, it seems it could instead be a normal copyable object with constructors instead of create functions. This would make it easier to program with.

> WebCore/editing/EditingStyle.h:79
> +    void removeTextFillAndStroleColorsIfNeeded(RenderStyle*);

Typo: "strole colors"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.