[Webkit-unassigned] [Bug 49069] WebViewHost::reset() uses placement new.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49069


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73064|review?                     |review-
               Flag|                            |




--- Comment #3 from Kent Tamura <tkent at chromium.org>  2010-11-06 06:55:58 PST ---
(From update of attachment 73064)
View in context: https://bugs.webkit.org/attachment.cgi?id=73064&action=review

> WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp:1111
> +    m_policyDelegateEnabled = false;
> +    m_policyDelegateIsPermissive = false;
> +    m_policyDelegateShouldNotifyDone = false;
> +    m_topLoadingFrame = 0;
> +    m_pageId = -1;
> +    m_lastPageIdUpdated = -1;
> +    m_hasWindow = false;
> +    m_inModalLoop = false;
> +    m_smartInsertDeleteEnabled = true;
> +#if OS(WINDOWS)
> +    m_selectTrailingWhitespaceEnabled = true;
> +#else
> +    m_selectTrailingWhitespaceEnabled = false;
> +#endif
> +    m_blocksRedirects = false;
> +    m_requestReturnNull = false;
> +    m_isPainting = false;
> +    m_canvas.clear();

We had better reset the followings too:
m_pendingExtraData
m_resourceIdentifierMap
m_currentCursor
m_windowRect
m_clearHeaders
m_editCommandName
m_editCommandvalue
m_paintRect

Some of them don't need to be reset.  But we should be consistent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.