[Webkit-unassigned] [Bug 36171] [Qt] QtWebKit doesn't support NPAPI for DirectFB

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36171


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73107|review?                     |review-
               Flag|                            |




--- Comment #32 from Antonio Gomes <tonikitoo at webkit.org>  2010-11-06 06:46:59 PST ---
(From update of attachment 73107)
View in context: https://bugs.webkit.org/attachment.cgi?id=73107&action=review

Basically, I would like to see all X11 related code guard by x11 defines.

> WebCore/bridge/npapi.h:92
> +#if defined(XP_UNIX) && !defined(XP_DFB)

I'd prefer if you did:

#if defined(XP_UNIX) && defined(X_PROTOCOL)

So you'd be including X-related stuff when it is X.

> WebCore/bridge/npapi.h:246
> +#if defined(XP_UNIX) && !defined(XP_DFB)

Ditto.

> WebCore/bridge/npruntime_internal.h:32
> +#if defined XP_UNIX && !defined(XP_DFB)

Ditto

> WebCore/plugins/PluginView.cpp:373
> +#if defined(XP_X11) && !defined(XP_DFB)

here you could do:

#if defined(XP_X11_ && PLATFORM(X11)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.