[Webkit-unassigned] [Bug 49118] Use IAccessibleComparable to compare accessibility objects.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49118


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73150|review?                     |review-
               Flag|                            |




--- Comment #2 from chris fleizach <cfleizach at apple.com>  2010-11-05 17:55:39 PST ---
(From update of attachment 73150)
View in context: https://bugs.webkit.org/attachment.cgi?id=73150&action=review

just one minor change, otherwise looks ok

> WebKitTools/DumpRenderTree/AccessibilityUIElement.h:-74
> -    

i think we should remove the #if #else, then put this default implementation in AccessibilutyUIElement.cpp as

#if !PLATFORM(WIN)
...
#endif

that way the header is easier to parse

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.