[Webkit-unassigned] [Bug 49004] Enable running of Qt API tests on BuildBot

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49004


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72949|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Csaba Osztrogonac <ossy at webkit.org>  2010-11-05 15:51:43 PST ---
(From update of attachment 72949)
View in context: https://bugs.webkit.org/attachment.cgi?id=72949&action=review

Otherwise LGTM, r=me with these changes.
Bill, could you execute a reconfigure on buildbot master after this patch landed?

> WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:337
> +    def evaluateCommand(self, cmd):
> +        if self.incorrectLines:
> +            return FAILURE

Qt API tests are quite stable, but I think 
we shouldn't block the bots if it fails.

I prefer using WARNINGS instead of FAILURE.

> WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:342
> +        if cmd.rc != 0:
> +            return FAILURE
> +
> +        return SUCCESS

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.