[Webkit-unassigned] [Bug 48812] FrameLoader::checkLoadCompleteForThisFrame uses wrong history item

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48812





--- Comment #15 from Charles Reis <creis at chromium.org>  2010-11-05 15:34:15 PST ---
(From update of attachment 73130)
(In reply to comment #13)
> (From update of attachment 72886 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72886&action=review
> 
> > WebCore/loader/FrameLoader.cpp:2385
> > +                    // Do not change the history if the backForward controller
> > +                    // is aleady loading a new URL.
> > +                    if (pdl->request().url() == page->backForward()->currentItem()->url()) {
> 
> URL can't be the right thing to use here.  What if all the pages in the back-forward list have the same URL?  Wouldn't that case still have the corruption?

Yeah, I'm still trying to figure this one out.  Darin, do you have any ideas how to tell whether the DocumentLoader is loading a request that matches the backForward()'s HistoryItem or not?  I'm having trouble finding another way to tell if we've gone on to a new back navigation, since the FrameLoader doesn't seem to have any other knowledge of it.

Anyway, I've uploaded a patch with a layout test draft.  It's not finished yet-- I still need to implement queueBackTwiceNavigation() in the various LayoutTestControllers, but it does let me successfully test for the bug.  (It tells the browser to go back and then back again before the first one commits.  JavaScript code doesn't seem able to do this.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.