[Webkit-unassigned] [Bug 27165] Connections-per-host should be tracked closer to the ResourceHandle level, not the Cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27165


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72883|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #36 from Alexey Proskuryakov <ap at webkit.org>  2010-11-05 11:35:26 PST ---
(From update of attachment 72883)
View in context: https://bugs.webkit.org/attachment.cgi?id=72883&action=review

>> Did this test pass in Firefox and IE in its original form? If it did, we should probably find a way to keep it working.
> The data I provided before was for the original form.  I can get it for the new form of the test if you like, but I was mostly pointing out that behavior on this test isn't standard as is.

So, we used to be compatible with Firefox and IE8, and no longer are. This seems quite unfortunate. Perhaps credentials should be stored immediately, not waiting for a request to actually start? Or maybe requests with explicit credentials should always get highest priority, to make sure that subsequent ones are properly authenticated (or logged out)?

I don't think this difference necessarily warrants r-, but logging out is such a sensitive area that one gets paranoid.

> WebCore/ChangeLog:5
> +        Need a short description and bug URL (OOPS!)

As it says :)

> WebCore/loader/loader.cpp:185
> -    LOG(ResourceLoading, "Host '%s' received %s. Current count %d\n", m_name.string().latin1().data(), resource->url().latin1().data(), m_requestsLoading.size());
> +    LOG(ResourceLoading, "Received %s.", resource->url().latin1().data());

%s should probably be in single quotes, too (I think I omitted those by mistake when recently adding the logging).

> WebCore/loader/loader.cpp:224
> +    LOG(ResourceLoading, "Failed to load %s (cancelled=%d).\n", resource->url().latin1().data(), cancelled);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.