[Webkit-unassigned] [Bug 49066] Convert to and from DOMTimeStamp with converter functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49066


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73072|review?                     |review+
               Flag|                            |




--- Comment #7 from Adam Barth <abarth at webkit.org>  2010-11-05 10:26:53 PST ---
(From update of attachment 73072)
View in context: https://bugs.webkit.org/attachment.cgi?id=73072&action=review

Thanks!  Much easier to understand.  :)

> WebCore/platform/android/GeolocationServiceAndroid.cpp:175
> -    DOMTimeStamp currentTimeMillis = WTF::currentTime() * 1000.0;
> -    DOMTimeStamp maximumAgeMillis = 10 * 60 * 1000;  // 10 minutes
> +    DOMTimeStamp currentTimeMillis = convertSecondsToDOMTimeStamp(WTF::currentTime());
> +    DOMTimeStamp maximumAgeMillis = convertSecondsToDOMTimeStamp(10 * 60); // 10 minutes

Should we rename these variables?  currentTimeStamp, etc?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.