[Webkit-unassigned] [Bug 48706] Factor calculation of cache sizes based on cache model into shared function.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 5 08:30:21 PDT 2010


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
  Attachment #72426|review?                     |review+
               Flag|                            |

--- Comment #4 from Adam Roben (aroben) <aroben at apple.com>  2010-11-05 08:30:21 PST ---
(From update of attachment 72426)
View in context: https://bugs.webkit.org/attachment.cgi?id=72426&action=review

> WebKit2/WebProcess/WebProcess.h:106
> +    void calculateCacheSizes(CacheModel cacheModel, uint64_t memorySize, uint64_t diskFreeSize,

Seems like this can be a static member function.

> WebKit2/WebProcess/mac/WebProcessMac.mm:67
>  void WebProcess::platformSetCacheModel(CacheModel cacheModel)
>  {
> +    NSURLCache *nsurlCache = [NSURLCache sharedURLCache];

Why did you move this up to the top? Was it a bug that it was lower down before? You should explain this in your ChangeLog.

> WebKit2/WebProcess/mac/WebProcessMac.mm:94
> +    [nsurlCache setDiskCapacity:std::max(urlCacheDiskCapacity, [nsurlCache diskCapacity])]; // Don't shrink a big disk cache, since that would cause churn.

Why is std:: needed here? Normally we use "using namespace std;" so you don't have to write that.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list