[Webkit-unassigned] [Bug 49062] Generate the messages sent to the WebProcessProxy

Fri Nov 5 08:27:34 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=49062

Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73050|review?                     |review+
               Flag|                            |

--- Comment #2 from Adam Roben (aroben) <aroben at apple.com>  2010-11-05 08:27:34 PST ---
(From update of attachment 73050)
View in context: https://bugs.webkit.org/attachment.cgi?id=73050&action=review

> WebKit2/Scripts/webkit2/messages.py:253
> +        'WebCore::PluginData.h',

The ".h" seems wrong.

> WebKit2/UIProcess/WebProcessProxy.cpp:232
> +void WebProcessProxy::didPerformClientRedirect(uint64_t pageID, const String& sourceURLString, const String& destinationURLString, uint64_t frameID)
> +{
> +    m_context->didPerformClientRedirect(webFrame(frameID), sourceURLString, destinationURLString);
> +}

Will the unused pageID variable cause compiler warnings/errors?

Why are we sending along the pageID if we don't need it?

(These questions apply to a few other functions in this file.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.