[Webkit-unassigned] [Bug 44256] [EFL] Private Browsing feature for WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44256


Grzegorz <g.czajkowski at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |g.czajkowski at samsung.com,
                   |                            |miroslaw.s at samsung.com




--- Comment #8 from Grzegorz <g.czajkowski at samsung.com>  2010-11-05 08:15:13 PST ---
1) I moved a function _ewk_cookie_jar_replace to ewk_cookies.h

2) I changed the name of feature to Incognito Browsing Feature because WebKit already has private browsing for the Pages.

3) I changed condition - if we alredy are in incognito mode we return EINA_TRUE.

4) Needed information regarding to cookies are stored in Ewk_Incognito_Cookies struct. Definition of this struct is puted to ewk_cookies.cpp. I think it's not necessary to include it to ewk_cookies.h because only _ewk_jookie_jar_replace uses it.

5) Static variables are moved to _ewk_incognito_cookie_get() - they are needed in this case - I think.

6) Added docs.

7) Changelog has high-level summary.

I would like to know your opinion on that.
Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.